Skip to content

ARSN-587: require content md5 in signed headers#2633

Open
leif-scality wants to merge 2 commits into
development/8.4from
bugfix/ARSN-587-require-content-md5-in-signed-headers
Open

ARSN-587: require content md5 in signed headers#2633
leif-scality wants to merge 2 commits into
development/8.4from
bugfix/ARSN-587-require-content-md5-in-signed-headers

Conversation

@leif-scality

@leif-scality leif-scality commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Require the Content-MD5 to be in the signed headers if present in the request like mentioned in the AWS doc here

@bert-e

bert-e commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue ARSN-587 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.4.5

Please check the Fix Version/s of ARSN-587, or the target
branch of this pull request.

@claude

claude Bot commented Jun 5, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.66%. Comparing base (a1fa5b4) to head (b661155).

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.4    #2633   +/-   ##
================================================
  Coverage            73.65%   73.66%           
================================================
  Files                  223      223           
  Lines                18247    18250    +3     
  Branches              3776     3778    +2     
================================================
+ Hits                 13440    13443    +3     
  Misses                4802     4802           
  Partials                 5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants