Use settings.xml repositories for parent POM resolution - #95
Merged
Conversation
The repositories parameter in loadEffectivePom was accepted but ignored. MavenModelResolver was constructed once at class level with only Maven Central, so parent POMs hosted on custom repos (Nexus, Artifactory, etc.) could not be resolved. Wire repositories from Maven settings.xml active profiles into MavenModelResolver by extracting them as Aether RemoteRepository objects and passing them through the loadEffectivePom call chain. Also construct MavenModelResolver per-call instead of sharing a single mutable instance, preventing repository state from leaking across calls. Fixes sbt#72
Contributor
Author
Contributor
|
@labianchin thank you for your contribution. |
Contributor
Author
Member
|
I don't actively maintain this plugin, but I'd be happy to land this and get it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repositories parameter in loadEffectivePom was accepted but ignored. MavenModelResolver was constructed once at class level with only Maven Central, so parent POMs hosted on custom repos (Nexus, Artifactory, etc.) could not be resolved.
Wire repositories from Maven settings.xml active profiles into MavenModelResolver by extracting them as RemoteRepository objects and passing them through the loadEffectivePom call chain. Also construct MavenModelResolver per-call instead of sharing a single mutable instance, preventing repository state from leaking across calls.