Respect settings.xml mirror repository definition - #90
Conversation
|
@iuliand-db thank you for your contribution. Do you mind to modify your changeset to be more flexible regardint to the
If you don't have time for that, I'll rework your PR, but it'd be a bit later in time. For reference, https://issues.apache.org/jira/browse/MNG-6603 |
Note that settings.xml were processed already from EDIT: I was wrong, there's a setting to point to the settings location. I pushed a new commit to respect the setting and added a scripted-test.
Looking a bit deeper into this, the original issue is still open, and there are some changes in maven 4 (currently, sbt-pom-reader depends on maven 3.9) to support
These are maven command line arguments, if I'm not mistaken, which don't have an equivalent in sbt. Since there's already an sbt setting to point to the settings.xml file, perhaps we can get 90% there by just respecting this setting (which can be configured to pick up environment variables if needed.
|
Noticed this in the Spark build. Internally we are using a maven mirror that we'd like to keep as a user setting, instead of adding it to code. Seems like other settings in settings.xml are picked up, so picking up any defined mirrors seems in line with the general approach.