fix: remove strict pdf extra dependency check on report import (closes #147) - #179
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
lightautoml/report/__init__.pyfile includes a call to__validate_extra_deps("pdf")at import time. This causes any import oflightautoml.automl.presets.tabular_presetsto fail if the optional pdf dependencies are not installed, even if the user only needs TabularAutoML/TabularUtilizedAutoML and has no intention of generating PDF reports.Fix
Removed the immediate validation call from
lightautoml/report/__init__.py. The optional dependencies will still be checked when actually using report functionality, if those modules perform the validation themselves (or this is now the responsibility of report users). This allows core imports to succeed without requiring thepdfextra.Closes #147