Skip to content

prompts: add more details for the PCI subsystem#293

Draft
kwilczynski wants to merge 1 commit into
sashiko-dev:mainfrom
kwilczynski:feature/linux-pci-review-prompts
Draft

prompts: add more details for the PCI subsystem#293
kwilczynski wants to merge 1 commit into
sashiko-dev:mainfrom
kwilczynski:feature/linux-pci-review-prompts

Conversation

@kwilczynski

Copy link
Copy Markdown
Contributor

The PCI subsystem has some specific needs and wants, so capture some of these for Sashiko. Perhaps with the extra content, Sashiko will be able to capture PCI-specific issues as part of the review process.

@kwilczynski kwilczynski force-pushed the feature/linux-pci-review-prompts branch 2 times, most recently from a15c25d to 4740668 Compare June 25, 2026 08:00
@rgushchin

Copy link
Copy Markdown
Member

Thanks, Krzysztof! Overall I like the change and it might make reviews better. Few concerns though:

  1. Who is supposed to do what? (Target Ambiguity)
    The prompt uses commands like "Add a changelog" or "Strip timestamps". Because the AI is reading this, it might get
    confused and think it needs to do those things, rather than checking if the patch author did them. We should change
    these to "Verify that the author..." so the AI knows its job is just to check.
  2. Checking things the sashiko can't see (Unverifiable Rules)
    Some rules ask the AI to check if the author waited a few days before reposting, addressed all previous feedback, or
    updated Patchwork. Sashiko only sees the single patch file and has no access to email history as of now. If we tell
    the AI to check these, it will just guess (hallucinate) or complain about things it can't actually verify. We should
    remove these workflow rules for now.
  3. Some redundancy in quick checks (maybe it's ok, but worth thinking of)
    The "Quick Checks" section at the end of the file is a copy-paste of almost all the rules we already explained in
    detail. This wastes tokens and means if we want to change a rule later, we have to update it in two places.
    We should clean it up to only include quick, unique checks.
  4. Missing reviews for PCI drivers (Trigger Gap)
    The prompt only loads if the file is inside drivers/pci/ . However, network, USB, or graphics drivers also use PCI
    functions. If a network driver has a bug in its PCI setup, this prompt won't load, and Sashiko will miss it. We should
    make the prompt load whenever common PCI functions are used anywhere in the codebase.

@kwilczynski

kwilczynski commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@rgushchin thank you for the feedback!

Some things that I didn't think about from the LLM angle. Let me incorporate some feedback from Bjorn, and then from you, and I will push revised document.

@kwilczynski kwilczynski marked this pull request as draft June 26, 2026 01:01
@kwilczynski kwilczynski force-pushed the feature/linux-pci-review-prompts branch from 4740668 to 4d0249d Compare June 26, 2026 01:10
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
@kwilczynski kwilczynski force-pushed the feature/linux-pci-review-prompts branch from 4d0249d to 108eded Compare June 27, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants