prompts: add more details for the PCI subsystem#293
Draft
kwilczynski wants to merge 1 commit into
Draft
Conversation
a15c25d to
4740668
Compare
Member
|
Thanks, Krzysztof! Overall I like the change and it might make reviews better. Few concerns though:
|
Contributor
Author
|
@rgushchin thank you for the feedback! Some things that I didn't think about from the LLM angle. Let me incorporate some feedback from Bjorn, and then from you, and I will push revised document. |
4740668 to
4d0249d
Compare
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
4d0249d to
108eded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PCI subsystem has some specific needs and wants, so capture some of these for Sashiko. Perhaps with the extra content, Sashiko will be able to capture PCI-specific issues as part of the review process.