fix(ace): harden reveal hooks and family previews#246
Open
bbugyi200 wants to merge 1 commit into
Open
Conversation
Propagate internal TypeError failures from stateful reveal hooks instead of retrying them with progressively narrower arguments. Load bounded family preview artifacts through the existing asynchronous detail worker so rendering remains free of disk reads on a cold cache. Add regression coverage for single-attempt hook calls and event-loop-safe family rendering. SASE_PLAN=[202607/fix_sase_update_stale_plugin_paths.md][1] SASE_AGENT=audit_bugs.sase.766469d7e5c1 SASE_MACHINE=athena [1]: https://github.com/sase-org/sase--plans/blob/main/202607/fix_sase_update_stale_plugin_paths.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ace): harden reveal hooks and family previews
Propagate internal TypeError failures from stateful reveal hooks instead of
retrying them with progressively narrower arguments.
Load bounded family preview artifacts through the existing asynchronous detail
worker so rendering remains free of disk reads on a cold cache.
Add regression coverage for single-attempt hook calls and event-loop-safe
family rendering.
Model:
codex/gpt-5.6-solAgent:
audit_bugs.sase.766469d7e5c1SASE_PLAN=202607/fix_sase_update_stale_plugin_paths.md
SASE_AGENT=audit_bugs.sase.766469d7e5c1
SASE_MACHINE=athena