Skip to content

Add integration tests - #66

Open
frostming wants to merge 52 commits into
add-testsfrom
add-tests-frost
Open

Add integration tests#66
frostming wants to merge 52 commits into
add-testsfrom
add-tests-frost

Conversation

@frostming

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
- Also clean up python specifiers

Signed-off-by: Dan Ryan <dan@danryan.co>
- Also add magic methods to MetaSet object
- Super fast and efficient now due to set comparisons
- Old method had sometimes thousands of the same pyspecs
- This consolidates as it builds

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>

Test fixes

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix specifier dedup logic

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix import

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix tox

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>

Add set operations and comparison methods to metasets

Signed-off-by: Dan Ryan <dan@danryan.co>

Add abstract extraction methods for marker cleanup

Signed-off-by: Dan Ryan <dan@danryan.co>

Add intersection method for PySpecs and smarter unions and creation

Signed-off-by: Dan Ryan <dan@danryan.co>

Simplify and cleanup metadata implementation

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy and others added 5 commits October 3, 2018 22:11
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@codecov

codecov Bot commented Sep 20, 2019

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@frostming

frostming commented Sep 26, 2019

Copy link
Copy Markdown
Member Author

Creating virtualenv for every test case is a big performance killer in testing.
I am considering to design a new (un)installation interface so that we can get a full mocked (un)installation and get rid of venv.

@frostming

Copy link
Copy Markdown
Member Author

Whoa, after mocking installation, the time cost is reduced by 60%!

@frostming
frostming marked this pull request as ready for review September 28, 2019 13:25
@frostming

frostming commented Sep 28, 2019

Copy link
Copy Markdown
Member Author

I am not apt to make huge PRs, so if the review is done we can start merging stuff. No need to have a full test suite at this point. Especially there are some bugfixes that are worth merging into the master. Do we need to cherry-pick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants