Skip to content

Missing second parameter to vcs.update - #63

Open
frostming wants to merge 1 commit into
sarugaku:masterfrom
frostming:patch-1
Open

Missing second parameter to vcs.update#63
frostming wants to merge 1 commit into
sarugaku:masterfrom
frostming:patch-1

Conversation

@frostming

Copy link
Copy Markdown
Member

Testing case:

[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[packages]
requests = {git = "https://github.com/requests/requests", ref = "master"}

[dev-packages]

It is great that passa can resolve non-editable VCS deps. Iooking forward to replacing pip-tools.

@uranusjr

uranusjr commented Dec 7, 2018

Copy link
Copy Markdown
Member

Does the second argument always exist? We’ll need to make sure this works with older pip versions.

@frostming

Copy link
Copy Markdown
Member Author

@uranusjr Oh no i didn't check that, it turns out it was introduced in v18.1 😢

@pradyunsg

Copy link
Copy Markdown

Yea, pip's VCS support code has been getting cleaned up and improved lately.

@techalchemy

Copy link
Copy Markdown
Member

wait why are we still using this directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants