Missing second parameter to vcs.update - #63
Open
frostming wants to merge 1 commit into
Open
Conversation
Member
|
Does the second argument always exist? We’ll need to make sure this works with older pip versions. |
Member
Author
|
@uranusjr Oh no i didn't check that, it turns out it was introduced in v18.1 😢 |
|
Yea, pip's VCS support code has been getting cleaned up and improved lately. |
Member
|
wait why are we still using this directly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing case:
It is great that passa can resolve non-editable VCS deps. Iooking forward to replacing pip-tools.