Updated ios-helper.js in order to work with newer versions of XCode - #154
Open
andrerinaldi wants to merge 3 commits into
Open
Updated ios-helper.js in order to work with newer versions of XCode#154andrerinaldi wants to merge 3 commits into
andrerinaldi wants to merge 3 commits into
Conversation
|
@andrerinaldi there is also one at https://github.com/sarriaroman/FabricPlugin/blob/master/hooks/lib/utilities.js#L32 which you may want to add to the pull request? Did it manage to install okay without changing this one |
Author
|
@814k31 the issue with |
danielmoczydlowski
approved these changes
Nov 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had this issue when installing the plugin:
Failed to install 'cordova-fabric-plugin': CordovaError: Using "requireCordovaModule" to load non-cordova module "xcode" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.
at Context.requireCordovaModule (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/Context.js:57:15)
at Object.removeShellScriptBuildPhase (/Users/andrearinaldi/projects/beghelli/brain/plugins/cordova-fabric-plugin/hooks/lib/ios-helper.js:78:29)
at module.exports (/Users/andrearinaldi/projects/beghelli/brain/plugins/cordova-fabric-plugin/hooks/after_plugin_add.js:21:19)
at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20
at process._tickCallback (internal/process/next_tick.js:68:7)
and I solved it as you can see.