Migrate logging to tracing#11
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the logging infrastructure from log4rs to the tracing framework, removes the old logging.rs module in favor of a new log.rs module, and adds a new force_mode configuration option to allow manual mode override.
Key changes:
- Replaced
log4rswithtracingandtracing-subscriberfor structured logging - Migrated all logging macros from
log::*totracing::*throughout the codebase - Added new
force_modeconfiguration parameter to force a specific radio mode
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/log.rs | New logging configuration module using tracing-subscriber with enhanced formatting options |
| src/logging.rs | Removed old log4rs-based logging module |
| src/main.rs | Updated logging macro calls, added force_mode logic to override radio mode detection, and refactored VFO mode/frequency retrieval |
| src/wavelog.rs | Migrated logging macros to tracing and applied code formatting improvements |
| src/config.rs | Added new force_mode configuration parameter and updated to use tracing::Level |
| src/errors.rs | Updated imports to use explicit Display and Formatter from std::fmt |
| Cargo.toml | Removed log4rs dependencies, added tracing ecosystem dependencies, and updated version to 1.3.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.