[Feature] Added ignore translation list - #8
Open
abnormalbbk wants to merge 3 commits into
Open
Conversation
abnormalbbk
commented
Aug 22, 2022
abnormalbbk
commented
sarbagyastha
requested changes
Aug 29, 2022
sarbagyastha
left a comment
sarbagyastha
left a comment
Owner
There was a problem hiding this comment.
Thank you for your contribution. I have added few comments.
| } | ||
|
|
||
| static void _replace(x, y) { | ||
| if (_ignoreList.contains(x)) return; |
| static String convert( | ||
| String text, { | ||
| bool live = false, | ||
| List<String> ignoreList = const [], |
Owner
There was a problem hiding this comment.
What do you think of using a Regex instead ?
Author
There was a problem hiding this comment.
i think it's an good idea. let me make the neccessary changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.