fix: annotate aarch64 fp16 vector helpers with target features - #45
Closed
K12231217 wants to merge 1 commit into
Closed
fix: annotate aarch64 fp16 vector helpers with target features#45K12231217 wants to merge 1 commit into
K12231217 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Annotate the four aarch64 helpers that emit 8-lane FP16 vector instructions with the function-level fp16 target feature:
The existing microkernel dispatch remains unchanged. This does not enable FP16 globally or raise the baseline CPU requirement for callers that do not enter the FP16-dispatched path.
Reproduction
The standalone workspace uses dev opt-level 3, which hides the issue. A top-level downstream workspace using an unoptimized debug profile reproduces it without additional CPU flags:
Before this change, LLVM rejects the instantiated vfmaq_laneq_f16 assembly with instruction requires: fullfp16.
Verification
Tested from the gemm-common 0.18.2 release baseline because that is the downstream dependency version exposing the failure.