Fix error on Next() when skipping files. - #5
Open
ajnavarro wants to merge 1 commit into
Open
Conversation
With this change, we discard remaining bytes for the actual file to avoid errors on partial reads or skipping files calling Next() without reading. Several optimizations are possible, like directly Seek to the next file without reading the previous one, if the underlying reader supports it. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Owner
|
Thank you for this @ajnavarro! I don't have much time at the moment, but I'll take a look at this, try it and refamiliarise myself with the codebase at the weekend.
I think the reason we're not directly seeking here is because we actually need to read and decompress the previous content in the "folder". Reading and discarding causes the underlying reader to decompress for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, we discard remaining bytes for the actual file to
avoid errors on partial reads or skipping files calling Next()
without reading.
Several optimizations are possible, like directly Seek to the next file
without reading the previous one, if the underlying reader supports it.
Signed-off-by: Antonio Navarro Perez antnavper@gmail.com