V2 resource apis - #919
Draft
wagnerd3 wants to merge 10 commits into
Draft
Conversation
Even if the creation of new commitments is disabled on a certain resource (e.g. in anticipation of the decommissioning of an old hardware family), if there are pre-existing commitments, we need to display commitment stats in the usual way for consistency purposes.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state:
/rates, e.g. direct access to entities by ID fromServiceInfoCache?with=options exist that we needed/resources/v2/projectwith our largest domain in our largest region is 10s computation, with all projects of the region it's 30s computation. That's not great, but acceptable, considering that in v1 the iteration through all domains produces some overhead that we save in v2TODO:
resources/v2/project, because this is quite a large data amount. the streaming implementation of v1 only works with list currently, not with object, but we can most likely make this workresources/v2/projectsetIn...Reportfunctions have a lot of duplication. Maybe we should implement a genericfunc Set(value any)on all structs and do this recursive? That does not help for values which are set on a higher level in the structure though, likescraped_at, forbid_autogrowth, max_quota, ......