Skip to content

replace SQL test fixture with imperative setup of DB records - #404

Merged
SuperSandro2000 merged 1 commit into
masterfrom
remove-sql-fixture
Jul 30, 2026
Merged

replace SQL test fixture with imperative setup of DB records#404
SuperSandro2000 merged 1 commit into
masterfrom
remove-sql-fixture

Conversation

@majewsky

Copy link
Copy Markdown
Contributor

This removes the only known usage of easypg.LoadSQLFile() in the wild, thus opening up a refactoring opportunity for me.

This removes the only known usage of easypg.LoadSQLFile() in the wild,
thus opening up a refactoring opportunity for me.
@majewsky
majewsky requested a review from a team as a code owner July 29, 2026 18:02
@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/castellum/internal/api 88.85% (ø)
github.com/sapcc/castellum/internal/test 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/castellum/internal/test/setup.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/castellum/internal/api/assets_test.go
  • github.com/sapcc/castellum/internal/api/errors_test.go
  • github.com/sapcc/castellum/internal/api/operations_test.go
  • github.com/sapcc/castellum/internal/api/resources_test.go
  • github.com/sapcc/castellum/internal/api/shared_test.go

@SuperSandro2000
SuperSandro2000 merged commit 96008d1 into master Jul 30, 2026
6 checks passed
@SuperSandro2000
SuperSandro2000 deleted the remove-sql-fixture branch July 30, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants