fix(config): accumulate plugins.tags across imports - #224
Merged
Conversation
Imported configs set plugins.tags but merge() dropped them, so a tag filter defined in an imported file had no effect. Union the tags like plugins.directories so an import only ever widens the filter (tags are any-match at load time). Documents the accumulate-vs-override split for list keys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
When a config imports another file,
merge()combined most fields but silently droppedplugins.tags. A tag filter defined in an imported config therefore had no effect: rules were loaded as if no filter existed. This unions the imported tags into the base, mirroring howplugins.directoriesalready accumulates.Why:
plugins.tagsis an any-match filter applied at plugin load time, so accumulation only ever widens it (an import can loosen the filter, never narrow it). Previously the field was write-only from an import's perspective, making modular tag configuration impossible.How to test
mise run test -- -run TestConfig_merge_PluginTagsAppended ./internal/config/Covers two cases: base and import tags combining into a union, and import tags flowing into an empty base.
Notes for reviewers
configuration.md: documents tag accumulation and the broader list-vs-scalar merge split (exclude,plugins.directories,plugins.tagsaccumulate; scalars and maps override).Checklist
mise run checkruns fmt, vet, lint, and test)🤖 Generated with Claude Code