cmd/jv: flag parsing and usage fixes

[scop]

No description provided.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (bbc9f89) 89.21% compared to head (b9a55db) 89.21%.
Report is 4 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files          10       10              
  Lines        2652     2651       -1     
==========================================
- Hits         2366     2365       -1     
  Misses        237      237              
  Partials       49       49              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[santhosh-tekuri]

check if out~="" instead of append; this makes it clear

[scop]

Not sure I quite got what you meant, but 8ffba32 at least simplifies it some.

[santhosh-tekuri]

I meant to say add if guard as shown below:

if *output != "" {
    valid := false
    for _, out := range validOutputs {
        If *output == out {
            valid = true
            break
        }
     }
     If !valid {
         fmt.Fprintln(os.Stderr, "output must be one of", strings.Join(validOutputs, ", "))
         os.Exit(2)
     }
}

[scop]

Done in b9a55db

[scop]

Looks like this is half obsolete as of 6.0.1, reworked remainders in #177, closing here.