Skip to content

feat: support truncated output and validation error should write in buffer - #110

Open
zedongh wants to merge 2 commits into
santhosh-tekuri:masterfrom
zedongh:master
Open

feat: support truncated output and validation error should write in buffer#110
zedongh wants to merge 2 commits into
santhosh-tekuri:masterfrom
zedongh:master

Conversation

@zedongh

@zedongh zedongh commented Mar 15, 2023

Copy link
Copy Markdown

for large file validation will cause mess error and output will be huge:

  1. support tuncated output should first level validation error
  2. validationError GoString concat using byte Buffer for better performance

@santhosh-tekuri

Copy link
Copy Markdown
Owner

could you please create individual PR for each commit.

regarding the truncated output, it needs some evaluation from my side and takes time.

since GoString change is simpler and straight forward, having separate PR will help in merge early;

@zedongh

zedongh commented Mar 15, 2023

Copy link
Copy Markdown
Author

ok,my pleasure here #111

And, for truncate commit, hope jv support -flag truncate, print few error and stop, rather than print all of error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants