feat: support truncated output and validation error should write in buffer - #110
Open
zedongh wants to merge 2 commits into
Open
feat: support truncated output and validation error should write in buffer#110zedongh wants to merge 2 commits into
zedongh wants to merge 2 commits into
Conversation
Owner
|
could you please create individual PR for each commit. regarding the truncated output, it needs some evaluation from my side and takes time. since GoString change is simpler and straight forward, having separate PR will help in merge early; |
Author
|
ok,my pleasure here #111 And, for truncate commit, hope jv support -flag truncate, print few error and stop, rather than print all of error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for large file validation will cause mess error and output will be huge: