Comprehensive project modernization: tests, upgrades, docs - #35
Open
santatamas wants to merge 1 commit into
Open
Comprehensive project modernization: tests, upgrades, docs#35santatamas wants to merge 1 commit into
santatamas wants to merge 1 commit into
Conversation
- Initialize Go modules (go.mod) with Go 1.25.1 - Upgrade tcell from v1.4.1 to v2.7.4 (updated import paths) - Upgrade gorilla/websocket to v1.5.3 - Replace deprecated io/ioutil with io package - Fix CIA vet errors (non-constant format strings in log.Printf) - Fix UnsetKey bit-clear logic (was &= 0<<col, now &= ^(1<<col)) Unit Tests (285 total): - MOS6510: 141 instruction tests covering all 56 opcodes - MOS6510: 11 status flag tests with clear/set verification - MOS6510: 7 stack operation tests (push/pop/LIFO/wrap) - CIA: 17 tests (keyboard matrix, interrupt, register I/O) - RAM: 22 tests (bank switching, CIA routing, ROM/RAM access) - VIC2: 38 tests (character conversion, color mapping) - numeric: 32 tests (byte ops, bit testing, roundtrips) - internals: 17 tests (command serialization) Angular Debug UI (upgraded from Angular 7 to Angular 19): - Migrated to standalone components (no NgModule) - Using new application builder - ES2022 target with bundler module resolution - Angular Material 19.2 with inline templates - RxJS 7.8, zone.js 0.15, TypeScript 5.5 Documentation: - Comprehensive README with architecture, usage, and API docs - docs/ARCHITECTURE.md - System design and data flow - docs/DEVELOPMENT.md - Development guide and testing - docs/DEBUG_UI.md - Debug UI protocol and usage Co-authored-by: Tamas Santa <2805399+santatamas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @santatamas 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Summary
This PR comprehensively modernizes the go-c64 emulator project:
Go Backend Upgrades
go.mod) - project was using GOPATH previouslyio/ioutilwith moderniopackage equivalentsUnsetKeybit-clear logic, vet errors in log.Printf callsComprehensive Unit Tests (285 total)
Angular Debug UI (Angular 7 → Angular 19)
@angular-devkit/build-angular:application)Documentation
What was tested
go buildsucceedsgo test ./...- all 285 tests passng build- Angular frontend builds successfully