Conversation
`_infix_type_recalculate_layout_recursive` had no `INFIX_TYPE_REVERSE_TRAMPOLINE` case, so the layout stage never descended into a function signature's return type or arguments. Structs declared inline in a signature whose members referenced named types kept the parse-time offsets computed while members were unresolved (size 0), so even after resolve, every scalar member collapsed to the same offset, causing wrong field reads/writes through struct typed args. Found this while editing Affix cookbook article about wrapping `libpng`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.