Fold 2026-08-16 live-run findings into the Workday/Engage skills - #56
Merged
Conversation
fill-workday-timesheet: mark validated (two weeks filled, saved, then submitted); add multi-week gap discovery with a heading assertion after every navigation (a Next Week click was silently dropped live); warn that Escape inside the dialog raises "Discard Changes?" (Continue keeps data); document the Tue-column `occluded` failure on chrome-cdp <= 0.2.1 with the DOM-id fallback; add the opt-in Phase 7 Review/Submit flow (no Review button = already submitted); point the per-week flow at the `workday-enter-week` recipe. record-engage-activity: the typed-date shift is now 6/6 (-1 day); keep enter-as-is-and-verify but state the expected outcome up front; add the billed-week catch-up read of Current Activities; point Phase 4 at the `engage-fill-activity` recipe. approve-workday-tasks: name the detail pane's `Related Actions Time Entry` button + `grid "Daily Totals"` sum as the open-item identity (the left list also matches a worker grep); forbid Bulk Approve; point the return hop at the `workday-approve-and-return` recipe. login-microsoft-sso: Engage's /account/login redirect returns to the requested URL, no re-nav needed. Recipes live in $XDG_CONFIG_HOME/chrome-cdp/recipes, outside the repo, because their inputs carry the client project name.
…s entry, bump versions, note workday-submit-week is external
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the four authored Workday/Engage skills with what a full live run (fill two weeks → submit → record Engage points → approve six tasks) taught, plus points each repeated flow at a saved
chrome-cdprecipe.Next Weekclick was silently dropped live);Escapeinside the dialog raises "Discard Changes?" (Continue keeps data); the Tue-columnoccludedfailure on chrome-cdp ≤ 0.2.1 with the DOM-id fallback (fix in fix: --by cell ranks candidates by grid, re-resolves replaced nodes, names the cover; key reports focused_id chrome-cdp-cli#30); opt-in Phase 7 Review/Submit (no Review button = already submitted); per-week flow is theworkday-enter-weekrecipe.engage-fill-activityrecipe.Related Actions Time Entry: …button +grid "Daily Totals"sum (a worker grep also matches the left list); never Bulk Approve; the return hop is theworkday-approve-and-returnrecipe./account/loginredirect returns to the requested URL.Recipes
workday-enter-week,workday-submit-week,engage-fill-activity,workday-approve-and-returnare referenced by name and live in$XDG_CONFIG_HOME/chrome-cdp/recipes/, deliberately outside the repo: their inputs carry the client project name and the skills' own rule is no client-identifying text in committed examples.Checks
make skills-doctor && make skills-catalog CHECK=1 && make suites-catalog CHECK=1pass;skills/README.mdregenerated for the new description.