This repository was archived by the owner on Dec 7, 2022. It is now read-only.
Update dependencies - #15
Open
JamesGlover wants to merge 11 commits into
Open
Conversation
added 11 commits
January 19, 2022 15:35
We're not actually using the database in development, so lets switch out MySQL for the null database.
Broad-scale update of dependencies.
Testing the actual Oracle integration is a pain, due to the difficulties in creating development oracle databases, or even building the gems. So we test the mocked adapter, which is far from ideal.
We were entirely lacking tests. Less importantly we lacked linting. This adds both.
- Remove redundand versionstrings file - Set RAILS_ENV at top of file - require 'bundler/setup' instead of bundler - require files eagerly - Remove APP_ROOT constant - Use File.read, not File.open to avoid leaving files open - Use Yaml.load_file - Extract next_sequence into its own method - Convert number to integer on initialization - Move content-type handling into the Sinatra methods - Hide presenter from Sinatra
- Run tests - Run linters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service had languished somewhat, so there are a few changes here to bring it up to standard: