LookFast End-to-End Example with development code included.#329
Open
ajspiel wants to merge 14 commits into
Open
LookFast End-to-End Example with development code included.#329ajspiel wants to merge 14 commits into
ajspiel wants to merge 14 commits into
Conversation
…of the primary modules for lookfast. Further work is needed to aligh these tests with OpenCSP standards and double check test data.
…nctionality to run additional analysis thresholds if supplied by ini file. Input specifications now also include the location of the de430t.bsp ephemeris file for celestial body analysis. Starting point for pointing estimate analysis and initial diagnostic plots.
…hiteboard sketches.
…ubmitting pull request for LookFast. I also added plotting an statistics output for the pointing estimate. This is primed, but not fully integrated into the Lookfast_main_VCLI_argparse workflow. There are also some notes in the Lookfast issue log and minor name changes of files.
…ttings file (containing Sandia file paths still). Example runs without all of the confusing other files. Pointing estimate has been integrated into workflow.
…ead of full file paths for checkpoint file. Also added check to interactively select camera calibration file if not specified. Update to gitignore
…t to check code sections. renamed the folder for the opencsp->app->lookback to loofast_wip because this is a backlog of work in progress files during development. the folder path contrib->app->LookFast contains the most up to date code and ini fiel example without unit tests.
…iated with LookFast end-to-end example pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this pull request is to integrate the current state of the LookFast code into the public repository including a functional end-to-end example that is being reviewed for release to OpenCSP Box this week.
Summary of changes
This is a large code dump with two sections of files. All of the files associated with this merge are backed up within Sandia's network storage.
Within the contrib->app->LookFast folder that will be created with this pull request lives the most up to date full example code and settings files. It has slightly diverged from development code once moved over to this folder location to prepare to release the full example.
Within the opencsp->app->lookfast_wip folder that will be created with this full request lives my entire backlog of functions, files, and obsolete development code and first crack at automatically generated unit tests (which did not pan out). These files do not need to be merged into the develop branch at this time, but I didn't see a pathway for the merge to only apply to specific folders short of creating a new branch.
Implementation notes
Current implementation was a systematic effort to create this new method from start to finish with time and budget allocated over unit test creation and specific documentation. It is acknowledged that there will be a lot of work to fully integrate this with OpenCSP's environment. Between the two folder locations mentioned above, there exists a duplication of many files and functions because of the copy over to the contrib folder when making the end-to-end example.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordinglyAdditional information
No additional information to include at this time.