Merge pull request #1 from rheone/pilot/batch-1 - #74
Closed
rheone wants to merge 1 commit into
Closed
Conversation
# Work ## Added - .NET 10 (`net10.0`) target framework - `IIPAddressRange.ToIPAddresses()` -- safe enumeration method capped at `MaxEnumerationExponent` - `MaxEnumerationExponent` property on all range types (default 12 = 4096 addresses) - `SubnetUtilities.FewestConsecutiveSubnetsFor` overload with `maxEnumerationExponent` parameter - Regex source generators for improved parsing performance - Partial class split for maintainability (`Subnet`, `IPAddressRange`, `AbstractIPAddressRange`, `BigEndianBitWrapper`) ## Changed - `SubnetUtilities.PrivateIPAddressRangesList` and `LinkLocalIPAddressRangesList` are now `readonly` (lazily initialized) - `AbstractIPAddressRange.Overlaps` -- symmetry restored (both directions now return `true`) - `IPAddressRange.TryExcludeAll` -- boundary guards at family min/max (no longer throws) - `Subnet` parsing and `IPAddressUtilities` parsing use `[GeneratedRegex]` where available - Package dependencies updated and centralized via `Directory.Packages.props` - Deterministic builds enabled - Language version set to C# 14 - XML documentation improved throughout all public APIs with RFC references - Exception types corrected (`InvalidOperationException` to `ArgumentException` where appropriate) ## Removed - `MacAddress` type (was `[Obsolete]` in v3.x) - replacement coming soon-ish in a new package - `DefaultIPAddressRangeComparer` (use `DefaultIIPAddressRangeComparer`) - Drops [Gulliver](https://github.com/sandialabs/gulliver) dependency ## Fixed - `AbstractIPAddressRange.Overlaps` asymmetry (inner.Overlaps(outer) returned `false`) - `ContainsAnyPrivateAddresses`/`ContainsAllPublicAddresses` endpoint heuristic producing incorrect results for ranges spanning private subnets - `IPAddressRange.TryExcludeAll` throwing `InvalidOperationException` at family max address - IComparable consistency across range types ### Deprecated (will be removed in future major version) - `GetEnumerator()` on any range type -- use `ToIPAddresses()` instead - `IIPAddressRange` implementing `IEnumerable<IPAddress>` -- use `ToIPAddresses()` explicitly - `Subnet.TryIPv6FromPartial(string, out IEnumerable<Subnet>)` -- to be replaced / improved by more explicit methods ## Testing - Comprehensive test suite expansion across all range types, comparers, converters, math, and utilities - `Subnet` tests split into partial files: factory, `IComparable`, `IEquatable`, `ISerializable`, operators - `IPAddressRange` tests split into partial files: factory, `IComparable`, `IEquatable`, `ISerializable`, operators - `AbstractIPAddressRange` tests split into: `IEnumerable`, `IFormattable`, `IIPAddressRange` - Smoke test project (`smoketests/`) validating the packed NuGet package on real runtimes ## Infrastructure - Benchmark project (`src/Arcus.Benchmarks/`) with BenchmarkDotNet for all major types - CI/CD pipeline rework: build, CodeQL, dependency review, OpenSSF Scorecard, and smoke-test workflows - `.slnx` solution format (replaces legacy `.sln`) - `CONTRIBUTING.md` with build, test, and PR guidance - EditorConfig consolidated to repository root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work
Added
net10.0) target frameworkIIPAddressRange.ToIPAddresses()-- safe enumeration method capped atMaxEnumerationExponentMaxEnumerationExponentproperty on all range types (default 12 = 4096 addresses)SubnetUtilities.FewestConsecutiveSubnetsForoverload withmaxEnumerationExponentparameterSubnet,IPAddressRange,AbstractIPAddressRange,BigEndianBitWrapper)Changed
SubnetUtilities.PrivateIPAddressRangesListandLinkLocalIPAddressRangesListare nowreadonly(lazily initialized)AbstractIPAddressRange.Overlaps-- symmetry restored (both directions now returntrue)IPAddressRange.TryExcludeAll-- boundary guards at family min/max (no longer throws)Subnetparsing andIPAddressUtilitiesparsing use[GeneratedRegex]where availableDirectory.Packages.propsInvalidOperationExceptiontoArgumentExceptionwhere appropriate)Removed
MacAddresstype (was[Obsolete]in v3.x) - replacement coming soon-ish in a new packageDefaultIPAddressRangeComparer(useDefaultIIPAddressRangeComparer)Fixed
AbstractIPAddressRange.Overlapsasymmetry (inner.Overlaps(outer) returnedfalse)ContainsAnyPrivateAddresses/ContainsAllPublicAddressesendpoint heuristic producing incorrect results for ranges spanning private subnetsIPAddressRange.TryExcludeAllthrowingInvalidOperationExceptionat family max addressDeprecated (will be removed in future major version)
GetEnumerator()on any range type -- useToIPAddresses()insteadIIPAddressRangeimplementingIEnumerable<IPAddress>-- useToIPAddresses()explicitlySubnet.TryIPv6FromPartial(string, out IEnumerable<Subnet>)-- to be replaced / improved by more explicit methodsTesting
Subnettests split into partial files: factory,IComparable,IEquatable,ISerializable, operatorsIPAddressRangetests split into partial files: factory,IComparable,IEquatable,ISerializable, operatorsAbstractIPAddressRangetests split into:IEnumerable,IFormattable,IIPAddressRangesmoketests/) validating the packed NuGet package on real runtimesInfrastructure
src/Arcus.Benchmarks/) with BenchmarkDotNet for all major types.slnxsolution format (replaces legacy.sln)CONTRIBUTING.mdwith build, test, and PR guidance