Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the development tooling/configuration for the project by adding a StyLua configuration and simplifying the Nix flake setup, along with a small Lua formatting adjustment.
Changes:
- Add a
.stylua.tomlformatter configuration for consistent Lua formatting. - Simplify
flake.nix/flake.lockby removingnix-gen-luarc-jsonand related lock entries. - Apply a minor formatting change in
lua/zen/init.luaconsistent with the formatter configuration.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lua/zen/init.lua |
Minor formatting change to a local assignment (StyLua-style). |
flake.nix |
Removes gen-luarc overlay and .luarc.json symlink shellHook, simplifying the devShell definition. |
flake.lock |
Cleans up lockfile entries corresponding to removed flake inputs. |
.stylua.toml |
Introduces StyLua formatting rules for the Lua codebase. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| devShells.default = pkgs.mkShell { | ||
| packages = with pkgs; [ | ||
| lua-language-server |
There was a problem hiding this comment.
Optional: .stylua.toml is added here, but the Nix devShell currently only includes lua-language-server. If you expect contributors using use flake/nix develop to run formatting, consider adding stylua to devShells.default.packages so the formatter is available in the dev environment.
Suggested change
| lua-language-server | |
| lua-language-server | |
| stylua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.