fix(clipboard): avoid sync event backpressure - #44
Merged
Conversation
Owner
|
This PR appears to downgrade the workspace version from |
shideneyu
force-pushed
the
fix/triple-clipboard-sync
branch
from
May 8, 2026 07:34
e954429 to
c86dad1
Compare
Contributor
Author
|
Fixed, thanks. Sorry about the force-push earlier. I should have kept the review history cleaner. The force-push from
The clipboard backpressure change itself is unchanged. |
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix clipboard sync instability when multiple devices are connected.
The sync runner was sending status events through a bounded channel using awaited sends. In long-running or multi-device clipboard sync sessions, this could allow the status event channel to apply backpressure
to the actual clipboard sync tasks.
This change makes sync status event delivery non-blocking, so a full status channel can no longer stall clipboard synchronization.
Changes
.send(...).awaitcalls for sync status events with non-blockingtry_send(...).