Add custom server URL on iOS login screen - #2111
Open
ibeckermayer wants to merge 1 commit into
Open
Conversation
Let users set custom_domain before login via a collapsible Advanced section on LoginViewController. Persist trimmed input through setCustomDomainPreference: and clear cachedURL so API calls pick up the new origin immediately without restarting. Wire logged-in Settings.bundle custom_domain changes through FeedsObjCViewController settingDidChange. Disable autocapitalization in createTextField for all login inputs. Add table-driven tests for bare, https, and http hostnames plus whitespace and clear cases.
Owner
|
Not bad but I'd want it to match Android. I'm on a retreat right now so I can't pull it up, but if you prompt your agent to look at how we do it on Android, it might come up wiht the same UI. And post a screenshot, if it looks good I'd gladly merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted this for my own purposes so wired it up: