Skip to content

Upstream - #123

Merged
sameerasw merged 4 commits into
developfrom
main
Oct 4, 2025
Merged

Upstream#123
sameerasw merged 4 commits into
developfrom
main

Conversation

@sameerasw

Copy link
Copy Markdown
Owner

This pull request updates the codebase to standardize the use of UInt32 for port numbers throughout the application, replacing the previous use of UInt16. This change ensures better consistency and future-proofs the handling of port values. Additionally, port validation logic has been added to prevent invalid port assignments, and related types, methods, and usages have been updated accordingly.

Port type standardization and validation:

  • Changed all port-related variables, properties, and method parameters from UInt16 to UInt32 across the codebase, including in AppState, WebSocketServer, QuickConnectManager, ADBConnector, and UI components like SaveAndRestartButton, ScannerView, and SettingsView. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]
  • Added validation to ensure ports are within the valid range (1...65535) when starting the WebSocket server and when initializing the app, falling back to port 8080 if needed. [1] [2]

Related updates and bug fixes:

  • Updated default port values and constants to use UInt32 instead of UInt16 in Constants.swift.
  • Updated port handling in UDP wakeup logic and QR code generation to use the new type and ensure proper conversion. [1] [2] [3]

Release and version update:

  • Bumped the app version in appcast.xml from 2.0.33 to 2.1.1, updating release details and minimum system version.

@sameerasw sameerasw self-assigned this Oct 4, 2025
@sameerasw
sameerasw merged commit 0193082 into develop Oct 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants