Conversation
fix the high port number issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the codebase to standardize the use of
UInt32for port numbers throughout the application, replacing the previous use ofUInt16. This change ensures better consistency and future-proofs the handling of port values. Additionally, port validation logic has been added to prevent invalid port assignments, and related types, methods, and usages have been updated accordingly.Port type standardization and validation:
UInt16toUInt32across the codebase, including inAppState,WebSocketServer,QuickConnectManager,ADBConnector, and UI components likeSaveAndRestartButton,ScannerView, andSettingsView. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Related updates and bug fixes:
UInt32instead ofUInt16inConstants.swift.Release and version update:
appcast.xmlfrom2.0.33to2.1.1, updating release details and minimum system version.