Skip to content

Bug with optimize-path-order , scale issue #105

Closed

Description

@ErwanMAS

When i use --optimize-path-order on this file :
https://github.com/user-attachments/assets/62a4d3ec-64b1-411a-beef-8b73aaf247eb ,
the reordering seem to be good , but every thing is scaling down by 3.77735

Activity

  1. ErwanMAS commented on Mar 24, 2026

    @ErwanMAS
    ContributorAuthor

    @sameer if i do this change , my tests are working .

    But i don't think this is the legitimate fix , but i struggle to understand Rust .

    --- a/lib/src/converter/mod.rs
    +++ b/lib/src/converter/mod.rs
    @@ -287,7 +287,7 @@ fn svg2strokes_optimized(
         let mut collect_visitor = ConversionVisitor {
             terrarium: Terrarium::new(DpiConvertingTurtle {
                 inner: StrokeCollectingTurtle::default(),
    -            dpi: config.dpi,
    +            dpi: 25.4,
             }),
             _config: config,
             options,
    
  2. added a commit that references this issue on Mar 25, 2026
    a543a08
  3. sameer commented on Mar 25, 2026

    @sameer
    Owner

    Thanks for pointing this out, fixed!

  4. sameer commented on Mar 25, 2026

    @sameer
    Owner

    BTW I just merged the selector work in #106 🙂

  5. added a commit that references this issue on Mar 25, 2026
    f00f36d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions