Align plugin install name with manifest (sambanova-plugin-cc)#10
Merged
Conversation
The marketplace catalog entry named the plugin `samba-plugin` while the plugin's own manifest (and its MCP server, skills, and hooks) named it `sambanova-plugin-cc`. Claude Code installs under the catalog name but reads the manifest name for its identity, so the two disagreeing caused install/ update tracking friction and an inconsistent MCP tool prefix. Unify on the manifest name `sambanova-plugin-cc`: - marketplace.json: plugin entry name -> sambanova-plugin-cc (source path unchanged) - README: install command -> /plugin install sambanova-plugin-cc - add a guard test asserting the marketplace entry name matches the manifest name, so this can't drift again (sibling to the existing plugin/server name-parity test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The plugin had two conflicting identities:
marketplace.jsonplugin entry (install name) + READMEsamba-pluginplugin.jsonmanifest + MCP server + all skills + hookssambanova-plugin-ccClaude Code installs under the marketplace catalog name but reads the manifest name for the plugin's identity (and the MCP tool prefix). With the two disagreeing, install/update tracking gets confused and the identity is inconsistent.
Fix
Unify on the manifest name
sambanova-plugin-cc(matches the repo, the MCP server, the skills, and hooks — the bulk of the references):marketplace.json: plugin entryname→sambanova-plugin-cc(thesourcepath is unchanged).README.md: install command →/plugin install sambanova-plugin-cc.test_marketplace_plugin_name_matches_manifest, a sibling to the existing plugin/server name-parity test, so the twonamefields can never silently drift apart again. (Verified it fails on the old mismatch and passes now.)Note for existing users
Because the install name changes, anyone who installed the plugin as
samba-pluginshould reinstall under the new name:Testing
Offline suite:
69 passed, 2 skipped(+1 new guard test).