Repository navigation
Fix #3: strip configured call-expression statements - #10
Merged
Merged
Conversation
Implement removal of configured standalone call-expression statements (including dotted paths like console.log) while keeping debugger and inline expression behavior unchanged for this issue scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
functionsoption matching.console.logandlogger.debug.Issues
How to test
npm run checknpm run buildNotes
Learning notes
Scope-first implementation to avoid cross-issue coupling
What it is
Scope-first implementation means shipping one clearly bounded behavior per issue, even when you can see adjacent improvements. It keeps review size small and prevents hidden coupling between features.
Where it appears in this PR
src/index.tsaddsstripConfiguredCallExpressions()for standalone configured calls, while explicitly leaving chain-edge handling out of this change.Why it was the right call here
The alternative was combining call stripping with chained-call safety and map-generation refactors in one PR. That would increase risk and make regressions harder to attribute. By separating concerns, this PR validates core matching semantics first, and later issues can focus on correctness edges with targeted tests.
If you want to go deeper
Search: "incremental architecture" and "small batch size in code review".