chore: привести repository в package.json к виду, пригодному для npm provenance - #2995
Conversation
📝 WalkthroughWalkthroughPackage manifests across packages and utilities standardize Git repository URLs and monorepo directory mappings. Selected manifests also update contributor metadata and compact the published files declaration. ChangesPackage metadata updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "keywords": ["design-system", "react-components", "ui-kit", "react"], | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "ssh://git@github.com:salute-developers/plasma.git", |
There was a problem hiding this comment.
[Note]:
это гибрид схемы ssh:// и scp-синтаксиса с двоеточием. Формально невалидный URL: new URL(...) кидает ERR_INVALID_URL, потому что salute-developers парсится как порт.
Почему "работало"?
Проходит он только благодаря лояльному регекспу hosted-git-info, который при публикации приводит его к git+ssh://git@github.com/salute-developers/plasma.git - именно в таком виде он и лежит сейчас в реестре у например, @salutejs/sdds-serv@0.357.0
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2995/ |
| "styled-components": "5.3.1", | ||
| "ts-node": "10.2.1" | ||
| }, | ||
| "contributors": ["Виноградов Антон Александрович", "Зубаиров Фаниль Асхатович", "Vasiliy Loginevskiy"], |
There was a problem hiding this comment.
[Note]:
Приводим к одному виду
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/plasma-tokens-b2c/package.json`:
- Line 60: Standardize the contributors email to salute.developers@gmail.com in
the contributors arrays of packages/plasma-tokens-b2c/package.json at lines
60-60, packages/plasma-tokens-core/package.json at lines 23-23, and
packages/plasma-tokens-web/package.json at lines 60-60.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7fe936b3-e513-49ec-90d8-486f5bb7f56d
📒 Files selected for processing (33)
packages/plasma-asdk/package.jsonpackages/plasma-b2c/package.jsonpackages/plasma-colors/package.jsonpackages/plasma-core/package.jsonpackages/plasma-giga/package.jsonpackages/plasma-homeds/package.jsonpackages/plasma-hope/package.jsonpackages/plasma-icons/package.jsonpackages/plasma-tokens-b2b/package.jsonpackages/plasma-tokens-b2c/package.jsonpackages/plasma-tokens-core/package.jsonpackages/plasma-tokens-web/package.jsonpackages/plasma-tokens/package.jsonpackages/plasma-typo/package.jsonpackages/plasma-web/package.jsonpackages/sdds-bizcom/package.jsonpackages/sdds-cs/package.jsonpackages/sdds-dfa/package.jsonpackages/sdds-finai/package.jsonpackages/sdds-insol/package.jsonpackages/sdds-netology/package.jsonpackages/sdds-os/package.jsonpackages/sdds-platform-ai/package.jsonpackages/sdds-sbcom/package.jsonpackages/sdds-scan/package.jsonpackages/sdds-serv/package.jsonpackages/themes/core-themes/package.jsonpackages/themes/plasma-themes/package.jsonpackages/themes/sdds-themes/package.jsonutils/api-tests/package.jsonutils/plasma-cy-utils/package.jsonutils/plasma-sb-utils/package.jsonutils/plasma-tokens-utils/package.json
What/why changed
Приводим поле
repositoryв порядок во всех публикуемых пакетах - это предусловие для npm trusted publishing и provenance.При публикации через OIDC реестр сверяет
repository.urlиз манифеста с URL репозитория из сертификата подписи Sigstore.Несовпадение или пустое значение - публикация падает с
E422 Failed to validate repository information.Бонусом, поправили поле contributors на
"contributors": ["salute.developers@gmail.com"],без указания отдельных разработчиков.Summary by CodeRabbit
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.384.1-canary.2995.30345748617.0 npm install @salutejs/plasma-b2c@1.626.1-canary.2995.30345748617.0 npm install @salutejs/plasma-colors@0.16.1-canary.2995.30345748617.0 npm install @salutejs/plasma-core@1.233.1-canary.2995.30345748617.0 npm install @salutejs/plasma-giga@0.353.1-canary.2995.30345748617.0 npm install @salutejs/plasma-homeds@0.353.1-canary.2995.30345748617.0 npm install @salutejs/plasma-hope@1.380.1-canary.2995.30345748617.0 npm install @salutejs/plasma-icons@1.243.1-canary.2995.30345748617.0 npm install @salutejs/plasma-new-hope@0.370.1-canary.2995.30345748617.0 npm install @salutejs/plasma-tokens@1.145.1-canary.2995.30345748617.0 npm install @salutejs/plasma-tokens-b2b@1.59.1-canary.2995.30345748617.0 npm install @salutejs/plasma-tokens-b2c@0.70.1-canary.2995.30345748617.0 npm install @salutejs/plasma-tokens-core@0.7.1-canary.2995.30345748617.0 npm install @salutejs/plasma-tokens-web@1.74.1-canary.2995.30345748617.0 npm install @salutejs/plasma-typo@0.47.1-canary.2995.30345748617.0 npm install @salutejs/plasma-web@1.628.1-canary.2995.30345748617.0 npm install @salutejs/sdds-bizcom@0.358.1-canary.2995.30345748617.0 npm install @salutejs/sdds-cs@0.362.1-canary.2995.30345748617.0 npm install @salutejs/sdds-dfa@0.356.1-canary.2995.30345748617.0 npm install @salutejs/sdds-finai@0.349.1-canary.2995.30345748617.0 npm install @salutejs/sdds-insol@0.353.1-canary.2995.30345748617.0 npm install @salutejs/sdds-netology@0.357.1-canary.2995.30345748617.0 npm install @salutejs/sdds-os@0.28.1-canary.2995.30345748617.0 npm install @salutejs/sdds-platform-ai@0.357.1-canary.2995.30345748617.0 npm install @salutejs/sdds-sbcom@0.358.1-canary.2995.30345748617.0 npm install @salutejs/sdds-scan@0.356.1-canary.2995.30345748617.0 npm install @salutejs/sdds-serv@0.357.1-canary.2995.30345748617.0 npm install @salutejs/core-themes@0.35.1-canary.2995.30345748617.0 npm install @salutejs/plasma-themes@0.57.1-canary.2995.30345748617.0 npm install @salutejs/sdds-themes@0.71.1-canary.2995.30345748617.0 npm install @salutejs/sdds-api-tests@0.15.1-canary.2995.30345748617.0 npm install @salutejs/plasma-cy-utils@0.163.1-canary.2995.30345748617.0 npm install @salutejs/plasma-sb-utils@0.234.1-canary.2995.30345748617.0 npm install @salutejs/plasma-tokens-utils@0.55.1-canary.2995.30345748617.0 # or yarn add @salutejs/plasma-asdk@0.384.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-b2c@1.626.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-colors@0.16.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-core@1.233.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-giga@0.353.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-homeds@0.353.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-hope@1.380.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-icons@1.243.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-new-hope@0.370.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-tokens@1.145.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-tokens-b2b@1.59.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-tokens-b2c@0.70.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-tokens-core@0.7.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-tokens-web@1.74.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-typo@0.47.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-web@1.628.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-bizcom@0.358.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-cs@0.362.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-dfa@0.356.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-finai@0.349.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-insol@0.353.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-netology@0.357.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-os@0.28.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-platform-ai@0.357.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-sbcom@0.358.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-scan@0.356.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-serv@0.357.1-canary.2995.30345748617.0 yarn add @salutejs/core-themes@0.35.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-themes@0.57.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-themes@0.71.1-canary.2995.30345748617.0 yarn add @salutejs/sdds-api-tests@0.15.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-cy-utils@0.163.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-sb-utils@0.234.1-canary.2995.30345748617.0 yarn add @salutejs/plasma-tokens-utils@0.55.1-canary.2995.30345748617.0