fix(landing): full-bleed app-tile icon, clipped by the tile corners#206
Merged
Conversation
…corners The icon was fixed at 72px with object-fit:contain inside a 104px tile, so it sat inset (centered with padding) and letterboxed non-square sources. Make the image fill the tile (100% + object-fit:cover, border-radius:inherit); the tile's existing overflow:hidden + border-radius clip the corners, so a square icon reads as a proper edge-to-edge app icon. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The app-tile icon was fixed at 72px with
object-fit: containinside the 104px tile, so it sat inset (padding around it) and letterboxed non-square sources — it didn't fill the container.Change
.tile imgnow fills the tile (width/height: 100%,object-fit: cover,border-radius: inherit). The tile already hasoverflow: hidden+border-radius, so the corners clip — a square icon renders as a proper edge-to-edge app icon.Verified
Rendered the real server output with a square icon: fills the tile edge-to-edge, corners clipped.
fmt+clippy -D warningsclean.Note: this expects a square
icon_url(full-bleed icons crop to fill if non-square). OrangeRock's square logo URL is pending from the user.🤖 Generated with Claude Code