Release 0.22.16#308
Merged
Merged
Conversation
The auto-update path for libffi added new entries with
platforms=["linux", "win32"], pointing at the libffi.org source
release URL. That tarball ships only configure/Makefile.am/msvcc.sh —
no ffi.h, no libffi-8.lib, no libffi-8.dll. Windows libffi has
always come from python/cpython-bin-deps, whose archive ships those
prebuilt artifacts under amd64/, win32/, and arm64/.
get_dependency_version("libffi", "win32") picks the highest-versioned
entry whose platforms list contains "win32". As soon as a new source
release (3.6.0 here) got added with win32 in its platforms, it
shadowed the cpython-bin-deps entry (3.4.4) for win32 — so the build
fetched the source tarball, and _ctypes.vcxproj failed with
`error C1083: Cannot open include file: 'ffi.h'` across every Windows
matrix entry on PR #308.
Same root cause as the existing 3.5.2 entry being ["linux"]-only:
that was effectively the correct state, just never enforced in the
auto-updater.
Two changes:
- relenv/pyversions.py: drop "win32" from the platforms list the
auto-updater writes for new libffi source releases. The
detect_cpython_bin_deps_versions() branch immediately below
handles the Windows-side entry (platforms=["win32"]) and stays
untouched.
- relenv/python-versions.json: drop "win32" from the existing
3.6.0 entry so the win32 build falls back to 3.4.4 cpython-bin-deps
and CI unblocks without waiting on a fresh auto-update run.
Auto-updater bug only; libffi 3.6.0 itself is fine on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated version bump for Python and bundled dependencies.
This PR will be merged automatically once CI passes, which will
trigger the release workflow.