Drive wheel build mode from kind instead of an arbitrary cmd input#299
Merged
Conversation
package-action.yml accepted a `kind` input but never used it. Its `cmd` input — what actually decided the wheel build — defaulted to a command that appends a PEP 440 local version (`+dev<sha>`) on every build, including release builds called from auto-release.yml. PyPI rejects local versions, so the latest deploy run blew up with "400 The use of local versions in '0.22.13+devd3eddac' is not allowed." Make `kind` the source of truth: kind == release -> python -m build --wheel --outdir dist/ otherwise -> ... --tag-build=+dev<sha> ... (existing dev path) Drop the now-redundant `package_command`/`cmd` plumbing from ci.yml, release.yml, and package-action.yml. auto-release.yml already passes kind=release, so the same change fixes the merge-triggered path too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-action.yml accepted a
kindinput but never used it. Itscmdinput — what actually decided the wheel build — defaulted to a command that appends a PEP 440 local version (+dev<sha>) on every build, including release builds called from auto-release.yml.PyPI rejects local versions, so the latest deploy run blew up with "400 The use of local versions in '0.22.13+devd3eddac' is not allowed."
Make
kindthe source of truth:kind == release -> python -m build --wheel --outdir dist/
otherwise -> ... --tag-build=+dev ... (existing dev path)
Drop the now-redundant
package_command/cmdplumbing from ci.yml, release.yml, and package-action.yml. auto-release.yml already passes kind=release, so the same change fixes the merge-triggered path too.