Pre-import Python release manager keys before sig verification#295
Merged
Conversation
Auto-update fails the first time a release manager rotates or a brand new release goes out before the key has propagated to the keyservers we poll. Today's 3.13.14 release tripped this: Thomas Wouters' key (7169605F62C751356D054A26A821E680E5FA6305) is on github.com/Yhg1s.gpg but not yet on keyserver.ubuntu.com, keys.openpgp.org, or pgp.mit.edu. python.org publishes the canonical per-RM key URLs at https://www.python.org/downloads/metadata/pgp/. Pull each of them directly at the start of create_pyversions so we never depend on keyserver freshness to verify a brand-new release. The existing keyserver fallback path stays in place for any future keys not on this list. Also fixes a stale literal-{url} formatting in the failure exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-update fails the first time a release manager rotates or a brand new release goes out before the key has propagated to the keyservers we poll. Today's 3.13.14 release tripped this: Thomas Wouters' key (7169605F62C751356D054A26A821E680E5FA6305) is on github.com/Yhg1s.gpg but not yet on keyserver.ubuntu.com, keys.openpgp.org, or pgp.mit.edu.
python.org publishes the canonical per-RM key URLs at https://www.python.org/downloads/metadata/pgp/. Pull each of them directly at the start of create_pyversions so we never depend on keyserver freshness to verify a brand-new release. The existing keyserver fallback path stays in place for any future keys not on this list.
Also fixes a stale literal-{url} formatting in the failure exception.