This repository was archived by the owner on Aug 28, 2026. It is now read-only.
Fix: make country code button a combobox - #3
Merged
Conversation
This is a fix for #2 The country code button should still have role="combobox". This role communicates that the component will open a listbox. This is the case of a Select-Only Combobox https://www.w3.org/WAI/ARIA/apg/example-index/combobox/combobox-select-only.html Fix broken tests
gulagha
approved these changes
Nov 11, 2022
Author
|
!merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #2.
From the discussion in #100143:
I should have asked this before the merge.
Also fixes broken tests.
Types of changes
Checklist: