Skip to content

refactor: streamline asset upload pipeline and add variant pagination - #15

Merged
sal94 merged 5 commits into
devfrom
feature/upload-pipeline-refactor
Dec 5, 2025
Merged

refactor: streamline asset upload pipeline and add variant pagination#15
sal94 merged 5 commits into
devfrom
feature/upload-pipeline-refactor

Conversation

@sal94

@sal94 sal94 commented Dec 5, 2025

Copy link
Copy Markdown
Owner
  • What/Why:
    • Extract upload pipeline into dedicated helpers (quota guard, metadata probe, storage write/rename, DB insert) with stage-aware error mapping to clean 500s.
    • Add base repository helpers and migrate AssetRepository to them; add a paginated variant listing.
    • Expose variant pagination on GET /assets/{asset_id}/variants.

Review focus

  • Upload error mapping: stage messages make sense and don’t leak internals; quota rollback is still triggered on failures.
  • Variant pagination: limit/offset bounds and ordering (descending by id) fit expected client usage.
  • Repo base: no behavioral regressions in asset queries; type safety maintained.

@sal94 sal94 self-assigned this Dec 5, 2025
@sal94
sal94 merged commit 776fe95 into dev Dec 5, 2025
2 checks passed
@sal94
sal94 deleted the feature/upload-pipeline-refactor branch December 5, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant