Conversation
Fix: app rename to host matching
Feature/auth gate api
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| async with AsyncClient( | ||
| transport=ASGITransport(app=fastapi_app), base_url="http://testserver" | ||
| transport=ASGITransport(app=fastapi_app), base_url="http://testserver/api" | ||
| ) as ac: |
There was a problem hiding this comment.
The API routes now live under /api, but the shared AsyncClient is initialized with base_url="http://testserver/api" while tests still call absolute paths like "/auth/signup" or "/albums". httpx discards the base path for absolute URLs, so these requests resolve to http://testserver/auth/signup and http://testserver/albums, which don’t exist on the app and will return 404 instead of exercising the real endpoints. This breaks every test that relies on the fixture. Use a root base_url or remove the leading slashes so requests include the /api prefix.
Useful? React with 👍 / 👎.
1 participant
No description provided.