Skip to content

Fix undefined variable $cat_checked and $tags_checked #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enescala wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix undefined variable $cat_checked and $tags_checked #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f5eae
Fix array access warning in generate_meta_tags method
enescala Jul 11, 2025
2d93c5c
Fix undefined variable $cat_checked and $tags_checked in render_metabox
enescala Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions classes/class-sailthru-content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,10 +440,15 @@ function generate_meta_tags() {
$image = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), 'full' );
$thumb = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), 'concierge-thumb' );

$post_image = $image[0];
$horizon_tags['sailthru.image.full'] = esc_attr( $post_image );
$post_thumbnail = $thumb[0];
$horizon_tags['sailthru.image.thumb'] = $post_thumbnail;
if ( ! empty( $image[0] ) ) {
$post_image = $image[0];
$horizon_tags['sailthru.image.full'] = $post_image;
}

if ( ! empty( $thumb[0] ) ) {
$post_thumbnail = $thumb[0];
$horizon_tags['sailthru.image.thumb'] = $post_thumbnail;
}
Comment on lines 440 to +451

Copilot AI Mar 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description and linked issue focus on initializing $tags_checked/$cat_checked, but this PR also changes meta tag generation for featured images. Please update the PR description/test plan to cover this additional behavior change, or split it into a separate PR so the scope matches the issue being fixed.

Copilot uses AI. Check for mistakes.
}

// expiration date
Expand Down
3 changes: 3 additions & 0 deletions classes/class-sailthru-meta-box.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ public function render_metabox( $post ) {
// Retrieves the global content options.
$options = get_option( 'sailthru_content_settings' );

$tags_checked = false;
$cat_checked = false;

if ( isset( $options['sailthru_interest_tag_options'] ) && !empty( $options['sailthru_interest_tag_options'] ) ) {
$tags_checked = in_array( 'wordpress_tags', $options['sailthru_interest_tag_options'], true ) ? true : false;
$cat_checked = in_array( 'wordpress_categories', $options['sailthru_interest_tag_options'], true ) ? true : false;
Expand Down
Loading