WIP: Jb50188 - #394
Conversation
Co-authored-by: Martin Kampas <martin.kampas@jolla.com>
Co-authored-by: Martin Kampas <martin.kampas@jolla.com>
|
This PR was split from PR #325 |
martyone
left a comment
martyone
left a comment
There was a problem hiding this comment.
Now I realized if we are adding UI for deploying RPM keys, then we should provide also UI for listing and removing existing keys. But those should be primarily provided on the device - it should be possible to check and remove user-deployed keys under settings.
| }); | ||
| connect(runner.get(), &RemoteProcessRunner::done, context_, | ||
| [=, runner = runner.get()](bool ok) { | ||
| functor(ok, runner->errorString()); |
There was a problem hiding this comment.
We should somehow gracefully handle older devices without sdk-deploy-key. It should be possible to check for exit code 127 here, which should mean "command not found", and return a message like tr("Device unsupported: \"%1\" command not found").arg(command) instead of runner->errorString() in that case.
I thought there would be an item in the settings menu on the device for key management |
|
Yup, that's what I meant. Or should I understand it so that you thought there already was one? At least I didn't find it on my 4.0.1 device. |
|
No, it's not ready yet |
2 participants
No description provided.