Standardize default arguments between R and command line and fix MAC thresholds - #62
Open
dvg-p4 wants to merge 3 commits into
Open
Standardize default arguments between R and command line and fix MAC thresholds#62dvg-p4 wants to merge 3 commits into
dvg-p4 wants to merge 3 commits into
Conversation
dvg-p4
marked this pull request as ready for review
October 13, 2022 20:25
Contributor
Author
|
I've tried setting the arguments as in this PR for a dockerized 1.1.6.1, and it seems to solve the issues I was seeing. I haven't explicitly done a test of this code yet--was having some difficultly installing from source locally. Is there a standard suite of tests you use for new SAIGE releases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #61, making the default max MAF set the same from the command line as it is in the R script (and claims to be in the help message).
This also acts as a workaround for #60, since if the threshold for
cateVarRatioMinMACVecExcludeMACCutoff_to_CollapseUltraRareis consistently 10.5 instead of 10, a region will never be exactly on the cutoff. However the odd behavior would probably still occur if a user manually set those flags to integer values.I did not change
dosage_zerod_MAC_cutoffsince I have not had a chance to test with imputed sets.