fix: accumulate remote schema diagnostics instead of overwriting (#116) - #119
Open
Adityakumar37 wants to merge 1 commit into
Open
fix: accumulate remote schema diagnostics instead of overwriting (#116)#119Adityakumar37 wants to merge 1 commit into
Adityakumar37 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
Problem
compileSchema's main compilation path accumulatesschemaErrors/schemaAnnotationscorrectly, but
addRemoteSchema(called once per entry inoptions.remotes) overwrotenode.schemaErrors/node.schemaAnnotationson every call instead of appending to them.It also never set
error.data.schemaId, unlike the root compilation path.As a result, registering multiple remotes only kept the last remote's diagnostics, and any
surviving error had
schemaId: undefined— losing provenance and potentially letting invalidremotes slip past
throwOnInvalidSchema.Fix
In
SchemaNode.ts→addRemoteSchema:error.data.schemaId, resolved from the remote'sown
$id(falling back to the resolvedurl), matching howcompileSchematags rootschema errors.
node.schemaErrors/node.schemaAnnotationsare now accumulated via.concat(...)instead of being reassigned, so registering multiple remotes retains all of their
diagnostics.
Tests
Added
src/tests/issues/issue116.remoteSchema.diagnostics.test.ts:and
schemaIds.Verification
schemaIds instead of just the last one.with the fix stashed out).