gh-38632: Fix .degrees() to return ETuple and add as_ETuples parameter - #42634
Open
Chaitanya140904 wants to merge 2 commits into
Open
gh-38632: Fix .degrees() to return ETuple and add as_ETuples parameter#42634Chaitanya140904 wants to merge 2 commits into
Chaitanya140904 wants to merge 2 commits into
Conversation
…parameter The .degrees() method on multivariate polynomials was documented to return an ETuple but actually returned a plain tuple in most backends. Changes: - multi_polynomial_element.py: return ETuple by default (was already returning ETuple via max_exp(), but now also supports as_ETuples=False) - multi_polynomial_libsingular.pyx: return ETuple by default (was returning plain tuple of Integers); add as_ETuples parameter - plural.pyx: return ETuple by default (was returning plain tuple); add as_ETuples parameter All three backends now accept as_ETuples=True (default, returns ETuple) and as_ETuples=False (returns plain tuple), consistent with the existing .exponents(as_ETuples=True) API. Fixes: sagemath#38632
|
Documentation preview for this PR (built with commit 574ffb4; changes) is ready! 🎉 |
ETuple does not support negative indexing, so changing the default return type from tuple to ETuple broke existing code like: self.polynomial().degrees()[-1] Fix: keep as_ETuples=False (plain tuple) as the default, so existing code is unaffected. Users who want ETuple can pass as_ETuples=True explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.degrees()method on multivariate polynomials is documented to returnan
ETuple, but in practice most backends returned a plaintuple, makingthe behavior inconsistent and the documentation incorrect.
What problem does this solve?