gh-42477: Normalize temporary path in docbuild doctest - #42632
Open
cxzhong wants to merge 1 commit into
Open
Conversation
|
Documentation preview for this PR (built with commit cb04b4a; changes) is ready! 🎉 |
jhpalmieri
approved these changes
Aug 6, 2026
Member
|
Marking as a blocker since without it there is a failing doctest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/varmay resolve under/private/varRoot cause
_extend_over_namespace_packages()deliberately canonicalizes bothsys.pathentries and the input directory withos.path.realpath(). The doctest compared the returned canonical path with the unnormalized string returned byTemporaryDirectory(). These strings can differ on macOS even though they identify the same directory.This changes only the doctest expectation; runtime behavior is unchanged.
Follow-up to #42477.
Testing
python src/bin/sage-runtests --warn-long 5.0 src/sage_docbuild/builders.py