Fix matrix0 documentation reference and compiler warnings - #42629
Open
cxzhong wants to merge 1 commit into
Open
Conversation
cxzhong
marked this pull request as ready for review
August 5, 2026 07:25
|
Documentation preview for this PR (built with commit 59a8810; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_set_to_producthook with literal documentationMatrix.__getitem__andMatrix.__setitem__Root cause
_set_to_productis acdefmethod and is not exposed as a Python class member, so Sphinx cannot resolve it as apy:methtarget. The uninitialized-index warnings are false positives from the generated C control flow, but they fail to prove to the compiler that the variables are assigned whenever their corresponding flags are set.Validation
matrix0.pyxwith no-Wmaybe-uninitializedwarningspython -m sage.doctest --warn-long 60 src/sage/matrix/matrix0.pyx(990 tests passed)reference/matricesHTML documentation successfully; the original unresolved-reference warning is gone