Remove SAGE_LOCAL from sage.config - #42606
Open
cxzhong wants to merge 1 commit into
Open
Conversation
|
Documentation preview for this PR (built with commit 5705567; changes) is ready! 🎉 |
Contributor
|
I don't have a very strong opinion on this, but I would prefer to "just" remove SAGE_LOCAL from the config.py file. For Kenzo, it should work to look in meson for it in SAGE_LOCAL, similar to how maxima is handled. |
cxzhong
force-pushed
the
agent/gh-42459-sage-local-prefix
branch
from
August 3, 2026 03:04
3f42b90 to
5705567
Compare
cxzhong
marked this pull request as ready for review
August 3, 2026 04:54
Contributor
Author
|
@tobiasdiez could you review this again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42459.
sage.configcontains build-time configuration, whileSAGE_LOCALis a runtime environment setting with a different meaning in Sage-the-Distro. KeepingSAGE_LOCALin both places made the generated Kenzo path use the Python venv instead of the non-Python installation prefix.This PR now:
SAGE_LOCALfromsage.config;KENZO_FASdirectly in Meson from an explicit-DSAGE_LOCALoption used by Sage-the-Distro;KENZO_FASempty in pure Meson builds so that ECL uses its normal search path;sage.config.SAGE_LOCAL;sage.env.SAGE_LOCALruntime-based, with the environment taking precedence and the active Python prefix as the pure-Python fallback;The runtime fallback restores the behavior that existed before
sage.config.SAGE_LOCALbecame unconditional: Sage-the-Distro still exports its non-Python prefix, while pure Python installations use their activesys.prefix.Testing
./sage -t src/sage/config_test.py— 8 passed.venv/bin/python3 -m pytest -q src/sage/config_test.py— 8 passedpython -m pytest -q src/sage/config_test.py— 8 passedruff check src/sage/config_test.pygit diff --check upstream/develop...HEADSAGE_LOCALunset-DSAGE_LOCAL="/tmp/sage 42606 local"; generatedconfig.pycompiled and its Kenzo/ThreeJS paths were verified📝 Checklist
⌛ Dependencies
None.