Do not advertise kernel subshell support - #42603
Open
cxzhong wants to merge 1 commit into
Open
Conversation
|
Documentation preview for this PR (built with commit e10c753; changes) is ready! 🎉 |
cxzhong
force-pushed
the
fix-42567-disable-kernel-subshells
branch
from
August 5, 2026 02:58
e10c753 to
ed73034
Compare
cxzhong
marked this pull request as ready for review
August 5, 2026 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sage now removes
kernel subshellsfrom the features advertised in itskernel_info_reply.With ipykernel 7, advertising this feature allows JupyterLab to route widget
comm messages to a kernel subshell running in another OS thread. Sage libraries
are not generally safe to enter from arbitrary threads; in particular, the
@interactexample in the issue reaches cypari2/PARI from that thread andsegfaults after the initial evaluation.
Filtering the unsupported feature keeps these callbacks on the main kernel
shell while preserving the other features reported by ipykernel.
Fixes #42567.
Validation
./sage -t --force-lib src/sage/repl/ipython_kernel/kernel.py(16 tests passed)contain
debuggerbut notkernel subshellsgit diff --check📝 Checklist
Documentation is unchanged because this only corrects kernel feature
negotiation.
⌛ Dependencies
None.