build/pkgs/ncurses: Track compatibility symlinks - #42597
Open
cxzhong wants to merge 1 commit into
Open
Conversation
|
Documentation preview for this PR (built with commit c501b6a; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ncurses package currently creates its compatibility symlinks in
spkg-postinst, aftersage-spkghas scanned the staged installation and generated the installed-file manifest. As a result, the links are not recorded and remain behind when ncurses is uninstalled.Move compatibility-link creation into
spkg-install.inand create the links under$SAGE_DESTDIR_LOCAL. This makes them part of the staged installation and therefore part of the package manifest. The obsolete post-install hook is removed, existing narrow files remain untouched, and the duplicated ABI-version iteration is collapsed.Validation
bash -n build/pkgs/ncurses/spkg-install.ingit diff --check upstream/develop...HEADA full ncurses rebuild was not run because this checkout does not contain the ncurses source tarball or a configured local package-build tree.