Handle characteristic-divisible fractional elliptic-curve morphisms - #42577
Open
harrshita123 wants to merge 2 commits into
Open
Handle characteristic-divisible fractional elliptic-curve morphisms#42577harrshita123 wants to merge 2 commits into
harrshita123 wants to merge 2 commits into
Conversation
harrshita123
force-pushed
the
fix/fractional-isogeny-scaling-factor
branch
from
July 24, 2026 12:13
54db848 to
bbaa84b
Compare
harrshita123
marked this pull request as ready for review
July 24, 2026 12:14
|
Documentation preview for this PR (built with commit f36f2d9; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42576.
Problem
EllipticCurveHom_fractional.scaling_factor()divided the numerator's scaling factor by the denominator in the base field. When the characteristic divided the denominator, both values could become zero, producing an undefined0/0.The same case exposed two related gaps in
to_isogeny_chain(): the quotient's inseparable degree was computed but not included in the resulting chain, and the ordinary characteristic-(p) kernel calculation retained too much (p)-torsion.Changes
Validation
ruff check --config .github/workflows/ruff.toml src/sage/schemes/elliptic_curves/hom_fractional.pypython3 -m py_compile src/sage/schemes/elliptic_curves/hom_fractional.pygit diff --checkThe checkout used for development does not contain a built Sage runtime, so the full Sage doctest command could not run locally. The added doctests are included for CI validation.
📝 Checklist
⌛ Dependencies
None.